Remove http_listen_port from server Agent config #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
osg-grafana
approved these changes
Jul 22, 2022
|
Docs are fine, and up to you if you want another pair of engineering eyes. |
pracucci
reviewed
Jul 25, 2022
There was a problem hiding this comment.
I don't think it's correct just removing them, because then we have other config options assuming the agent HTTP is listening to 12345. @krajorama ?
By default the port is set to 12345 |
krajorama
approved these changes
Jul 26, 2022
|
@osg-grafana I guess we should pick this change to 2.2 release branch to update the online documentation. Otherwise we might embarrass ourselves with a non working getting started guide? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes
http_listen_portandgrpc_listen_portfields fromserverconfig for the Agent.See more details about the deprecation here.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]