Update dskit to add functionality for using multiple runtimeconfig files #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 27, 2022 18:21
added 2 commits
July 28, 2022 15:50
56quarters
approved these changes
Jul 29, 2022
|
Held up by grafana/dskit#206 causing integration failures. |
replay
reviewed
Aug 1, 2022
cmd/mimir/help-all.txt.tmpl
Outdated
| @@ -1639,10 +1639,10 @@ Usage of ./cmd/mimir/mimir: | |||
| Enable running rule groups against multiple tenants. The tenant IDs involved need to be in the rule group's 'source_tenants' field. If this flag is set to 'false' when there are already created federated rule groups, then these rules groups will be skipped during evaluations. | |||
| -ruler.tenant-shard-size int | |||
| The tenant's shard size when sharding is used by ruler. Value of 0 disables shuffle sharding for the tenant, and tenant rules will be sharded across all ruler replicas. | |||
| -runtime-config.file string | |||
| File with the configuration that can be updated in runtime. | |||
| -runtime-config.file value | |||
There was a problem hiding this comment.
Actually this is still a string, but I'm guessing that it puts value there because of the flagext.StringSliceCSV type, right?
If it's easy then it would be nice if we could fix that, but otherwise it's not a blocker.
replay
approved these changes
Aug 1, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In dskit we added the ability to specify multiple runtime config files that will be merged together from left to right. Those merged files are then processed in Mimir for the runtime config. This PR enables that functionality inside of Mimir.
Which issue(s) this PR fixes or relates to
Fixes #1798
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]