mimirtool config: Update config descriptors #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
Aug 3, 2022
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
commented
Aug 3, 2022
pkg/mimirtool/config/gem.go
Outdated
Comment on lines
181
to
184
|
|
||
| // Removed in 2.1, 2.2 and 2.3 | ||
| "graphite.querier.enable_remote_subquerier", // -graphite.querier.enable-remote-subquerier | ||
| "graphite.querier.enable_remote_subquerier", // -graphite.querier.use-remote-results |
There was a problem hiding this comment.
These weren't in GEM 1.7
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
Aug 4, 2022
dimitarvdimitrov
force-pushed
the
dimitar/update-mimirtool-config-descriptors
branch
from
29550fc
to
bbd5796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com
What this PR does
Updates GEM and Mimir config descriptors before 2.3 release. Also updates tests to include any changed defaults and removed flags. The config descriptors taken are from the HEAD of main for both GEM and Mimir.
There aren't any config flag changes in any open PRs as of Aug 2, 12:45 UTC, so I think it's safe to commit the changes in this PR to the 2.3 release.
Which issue(s) this PR fixes or relates to
Fixes #2358
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]