Add instant splitter metrics stats #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssncferreira
commented
Aug 2, 2022
| package astmapper | ||
|
|
||
| type InstantSplitterStats struct { | ||
| splitQueries int |
There was a problem hiding this comment.
In addition to splitQueries we can also add a more detailed reason for a no operation. There are three possible causes:
- range interval smaller than configured split by time
- the call is a subquery
- none of the query expressions is splittable. This counter would be more difficult to keep track off because of the recursive logic on
MapExpr
There was a problem hiding this comment.
Looks a great idea. We can do in a follow up PR or add it to the TODO list in the issue and keep it for later. Up to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add instant splitting specific metric stats for instant query time splitting.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]