-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC support to query-tee #2683
Conversation
8ac8f2b
to
69cef88
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more things:
- Please add a CHANGELOG entry
- Can you add a phrase to
docs/sources/operators-guide/tools/query-tee.md
under "API endpoints", saying that the query-tee accept both HTTP requests and "HTTP over gRPC" requests, linking HTTP over gRPC to the library?
Co-authored-by: Marco Pracucci <marco@pracucci.com>
This comment has been minimized.
This comment has been minimized.
* Add weaveworks server configuration parameters * Use common metrics namespace * Update proxy tests to use port 0 * Update CHANGELOG * Update query-tee operator's guide documentation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
* Rename `server.service-port` to `server.http-service-port` * Rename configuration `ServerServicePort` to `ServerHTTPServicePort` * Add changelog entry for `server.http-service-port` and `cortex_querytee_backend_request_duration_seconds` * Update operators-guide/query-tee documentation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Helm <> Jsonnet Diff
If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag Please see the contribution docs here for more info. Expand to see the outputOutput of https://github.com/grafana/mimir/actions/runs/2875356531 Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/query-scheduler-MimirConfig.yml scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml
--- scratch/./helm/07-config/query-scheduler-MimirConfig.yml 2022-08-17 12:40:09.417323891 +0000
+++ scratch/./jsonnet/08-config/query-scheduler-MimirConfig.yml 2022-08-17 12:40:17.601479854 +0000
@@ -498,7 +498,7 @@
min_ready_duration: 15s (default)
observe_period: 0s (default)
replication_factor: 3 (default)
- tokens_file_path: /data/tokens
+ tokens_file_path: ' (default)'
zone_awareness_enabled: false (default)
tsdb_config_update_period: 15s (default)
ingester_client:
@@ -881,7 +881,7 @@
secondary: ' (default)'
store: memberlist (default)
replication_factor: 3 (default)
- tokens_file_path: /data/tokens
+ tokens_file_path: ' (default)'
unregister_on_shutdown: true (default)
wait_stability_max_duration: 5m0s (default)
zone_awareness_enabled: false (default) |
I've just manually tested this PR and looks working great! |
What this PR does
Add gRPC support to query-tee. This allows testing rule evaluations of rulers configured with remote operational mode via query-tee.
Query-tee now uses the weaveworks server implementation which creates 2 listening ports:
To test ruler evaluations with query-tee, update the ruler configuration
query-frontend.address
configuration to use query-tee's gRPC address:When the ruler evaluates a rule, the flow is the following:
Used for testing split by range epic: https://github.com/grafana/mimir-squad/issues/774
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]