Bring latest changes from mimir-prometheus #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the vendored version of mimir-prometheus. The highlights are: - Removed expensive atomic load call from head append. - Fixed out-of-order query bug that happened due to invalid LabelValues responses from the OOOHeadIndexReader that led to wrong query results. This issue was more common when query sharding was used together with out-of-order due to postings cache corruption. grafana/mimir-prometheus#314
This comment has been minimized.
This comment has been minimized.
colega
approved these changes
Aug 11, 2022
|
Should we mention this in the changelog? As a bugfix for OOO. |
pracucci
approved these changes
Aug 12, 2022
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
jesusvazquez
force-pushed
the
jvp/bring-changes-from-mimir-prometheus
branch
from
d3dc468
to
e705912
Compare
|
Changelog entry LGTM! Thanks. |
|
Helm <> Jsonnet Diff
If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag Please see the contribution docs here for more info. Expand to see the outputOutput of https://github.com/grafana/mimir/actions/runs/2845807676 Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/ingester-MimirConfig.yml scratch/./jsonnet/08-config/ingester-MimirConfig.yml
--- scratch/./helm/07-config/ingester-MimirConfig.yml 2022-08-12 09:32:54.486536415 +0000
+++ scratch/./jsonnet/08-config/ingester-MimirConfig.yml 2022-08-12 09:33:02.890577989 +0000
@@ -553,7 +553,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default)
diff -r -u -N scratch/./helm/07-config/overrides-exporter-MimirConfig.yml scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml
--- scratch/./helm/07-config/overrides-exporter-MimirConfig.yml 2022-08-12 09:32:54.490536435 +0000
+++ scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml 2022-08-12 09:33:02.894578009 +0000
@@ -498,7 +498,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the vendored version of mimir-prometheus.
The highlights are: