Extract instance limits check into middleware, that runs before any other distributor middlewares #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther middlewares (HA dedupe, forwarding). Added test to check that instance limits are called before HA deduplication. CHANGELOG.md Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
move-instance-limits-into-middleware
branch
from
9dc4fee
to
5418bd8
Compare
This comment has been minimized.
This comment has been minimized.
replay
reviewed
Aug 12, 2022
replay
reviewed
Aug 12, 2022
replay
reviewed
Aug 12, 2022
replay
approved these changes
Aug 12, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Thanks for your review @replay. I've addressed your feedback, please take a look again. |
This comment has been minimized.
This comment has been minimized.
replay
reviewed
Aug 12, 2022
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
replay
reviewed
Aug 12, 2022
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
|
Helm <> Jsonnet Diff
If you get stuck on this step and the Mimir maintainers aren't able to help, feel free to merge without making this step pass and tag Please see the contribution docs here for more info. Expand to see the outputOutput of https://github.com/grafana/mimir/actions/runs/2847701525 Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
diff -r -u -N scratch/./helm/07-config/ingester-MimirConfig.yml scratch/./jsonnet/08-config/ingester-MimirConfig.yml
--- scratch/./helm/07-config/ingester-MimirConfig.yml 2022-08-12 15:25:37.493639489 +0000
+++ scratch/./jsonnet/08-config/ingester-MimirConfig.yml 2022-08-12 15:25:46.961948798 +0000
@@ -553,7 +553,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default)
diff -r -u -N scratch/./helm/07-config/overrides-exporter-MimirConfig.yml scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml
--- scratch/./helm/07-config/overrides-exporter-MimirConfig.yml 2022-08-12 15:25:37.501639753 +0000
+++ scratch/./jsonnet/08-config/overrides-exporter-MimirConfig.yml 2022-08-12 15:25:46.973949184 +0000
@@ -498,7 +498,7 @@
max_fetched_chunks_per_query: 2000000 (default)
max_fetched_series_per_query: 0 (default)
max_global_exemplars_per_user: 0 (default)
- max_global_series_per_metric: 20000 (default)
+ max_global_series_per_metric: 0
max_global_series_per_user: 150000 (default)
max_label_name_length: 1024 (default)
max_label_names_per_series: 30 (default) |
replay
approved these changes
Aug 12, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
After merging #2603, instance limits checks are done only after running HA deduplication. That's not correct. This PR moves instance limits checks into its own middleware, and makes it the first middleware to run.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]