Update default for max_global_series_per_metric limit to 0 #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the CLI default and Helm chart in line with the Jsonnet default value. This default is set because it doesn't provide any protection for Mimir now that series are sharded by all labels (previously they were sharded only by metric name). It's still useful for preventing cardinality explosions in some cases but, more often it is a source of confusion for users. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/helm-jsonnet-diff
branch
from
1088439
to
c7a6c84
Compare
pstibrany
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This brings the CLI default and Helm chart in line with the Jsonnet
default value. This default is set because it doesn't provide any
protection for Mimir now that series are sharded by all labels
(previously they were sharded only by metric name). It's still useful
for preventing cardinality explosions in some cases but, more often
it is a source of confusion for users.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]