-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus-prefixed buildinfo endpoint to ruler #2724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pkg/api/api.go
Outdated
@@ -290,6 +290,7 @@ func (a *API) RegisterRuler(r *ruler.Ruler) { | |||
|
|||
// List all user rule groups | |||
a.RegisterRoute("/ruler/rule_groups", http.HandlerFunc(r.ListAllRules), false, true, "GET") | |||
a.RegisterRoute(path.Join(a.cfg.PrometheusHTTPPrefix, "/api/v1/status/buildinfo"), buildInfoHandler, false, true, "GET") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be moved to RegisterRulerAPI()
, which is where Prometheus-compatible APIs are expected to be registered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 1b3f213
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
eedf1ab
to
1b3f213
Compare
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com
What this PR does
Adds the
/prometheus
-prefixedbuildinfo
endpoint to the ruler. This endpoint is exposed by all other components (querier, query-frontend) that use the<prometheus-http-prefix>
, except the ruler.Which issue(s) this PR fixes or relates to
Fixes #2678
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]