Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track OOO setting via anonymous usage statistics #2940

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does

As requested by @jesusvazquez, in this PR I'm adding the tracking of the number of tenants with OOO ingestion enabled, and their min and max time window setting.

The min/max value is tracked even if 0. Then, when we'll aggregate it on the server side, I will filter out zero values. The reason why I'm also tracking the value of 0 is because the usage statistics currently don't easily allow to conditionally track a value.

Which issue(s) this PR fixes or relates to

Part of #1815

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR lgtm, but I would suggest to wait with merge until release-2.3 branch is merged to main, and rebase this PR first. This PR should not modify changelog entry for feature from 2.3 release.

Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for adding this @pracucci !

Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the track-out-of-order-window-setting branch from 5b735ca to c8ec036 Compare September 15, 2022 15:20
@pracucci pracucci enabled auto-merge (squash) September 15, 2022 15:21
@pracucci pracucci merged commit 8af7209 into main Sep 15, 2022
@pracucci pracucci deleted the track-out-of-order-window-setting branch September 15, 2022 15:36
@pstibrany pstibrany mentioned this pull request Sep 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants