distributor: Wrap errors from pushing to ingesters #3307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In the distributor component, wrap errors stemming from calling the push gRPC method on ingesters, making sure to maintain result status codes. If an errors stems from a timeout, that gets turned into an
httpgrpc
error with status code 500 and a specific message.I hope this will be useful in diagnosing write requests timing out in the ingester component (e.g. due to CPU starvation).
Which issue(s) this PR fixes or relates to
Fixes #3214
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]