Migration to dskit/ring #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, in dskit we should update metrics in the start fn and then start the ticker rather than do our first collect in 10 seconds, I'll create a PR for this tomorrow. grafana/dskit#61 |
|
Is this duplicate of #333? |
@pstibrany no, I think Tyler's PR is preferable :) |
Oh, that's too bad... you won the PR number lottery here :) |
pracucci
reviewed
Oct 12, 2021
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
reviewed
Oct 13, 2021
treid314
commented
Oct 13, 2021
…tCompactor_ShouldFailCompactionOnTimeout
pracucci
reviewed
Oct 18, 2021
bboreham
reviewed
Dec 23, 2021
| // metrics := initialRegistries.BuildMetricFamiliesPerUser() | ||
| // return metrics.GetSumOfGauges("cortex_ring_members") | ||
| // }) | ||
| dstest.Poll(t, 11*time.Second, float64(numAllGateways*numInitialGateways), func() interface{} { |
There was a problem hiding this comment.
This change from 5 seconds to 11 is worth calling out in the commit message.
There was a problem hiding this comment.
And should be rendered unnecessary by grafana/dskit#107, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: With including the ring package in dskit we want to migrate mimir and other users to the dskit.
Remaining work
TestStoreGateway_BlocksSyncWithDefaultSharding_RingTopologyChangedAfterScaleUpnot able to find ring members metricWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]