Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: Fix MimirCompactorSkippedBlocksWithOutOfOrderChunks #3628

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Dec 2, 2022

What this PR does

There component label does not exist. However, there is no need to filter on component as cortex_compactor_blocks_marked_for_no_compaction_total is only sent by the compactor.

Which issue(s) this PR fixes or relates to

Partial fixes #3366

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@jhesketh jhesketh requested a review from a team as a code owner December 2, 2022 06:16
CHANGELOG.md Outdated Show resolved Hide resolved
There `component` label does not exist. However, there is no need to
filter on component as
cortex_compactor_blocks_marked_for_no_compaction_total is only sent by
the compactor.
@jhesketh jhesketh force-pushed the read-write-deployment/alerts/MimirCompactorSkippedBlocksWithOutOfOrderChunks branch from ba7804a to 34d5935 Compare December 5, 2022 10:32
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pracucci pracucci merged commit a611b66 into grafana:main Dec 5, 2022
@jhesketh jhesketh deleted the read-write-deployment/alerts/MimirCompactorSkippedBlocksWithOutOfOrderChunks branch December 5, 2022 11:34
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
…3628)

* alerts: Fix MimirCompactorSkippedBlocksWithOutOfOrderChunks

There `component` label does not exist. However, there is no need to
filter on component as
cortex_compactor_blocks_marked_for_no_compaction_total is only sent by
the compactor.

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all alerts correctly work when Mimir is deployed using the read-write deployment mode
3 participants