Rollout operator psp #3686
Rollout operator psp #3686
Conversation
|
|
| @@ -30,6 +30,7 @@ Entries should include a reference to the Pull Request that introduced the chang | |||
|
|
|||
| * [ENHANCEMENT] Update the `rollout-operator` subchart to `0.2.0`. #3624 | |||
| * [ENHANCEMENT] Add ability to manage PrometheusRule for metamonitoring with Prometheus operator from the Helm chart. The alerts are disabled by default but can be enabled with `prometheusRule.mimirAlerts` set to `true`. To enable the default rules, set `mimirRules` to `true`. #2134 #2609 | |||
| * [BUGFIX] Enable `rollout-operator` to use PodSecurityPolicies if necessary | |||
There was a problem hiding this comment.
Isn't this more of an enhancement rather than a bug fix?
There was a problem hiding this comment.
On reading the changes (I'm unfamiliar with Helm), maybe it's a fix after all.
There was a problem hiding this comment.
Please run make build-helm-tests as the failing CI suggest to generate the proper golden records.
In general I think this should be fixed in the rollout-operator, with adding the same kind of controls that the mimir helm chart has (values under rbac key) with additional validation in mimir's templates/validate.yaml to keep them in sync. (Or even better we should have common settings for such things in grafana helm charts. But that's long term.)
However, given that PSP is being deprecated and this seems like an easy enough fix, I think we can approve it.
* make rollout-operator able to use psp * add new role-binding to generated templates * add changelog entry * add generated golden records
This commit updates Alertmanager to commit cab8ecb, which includes pull request #3686. This pull request changes a number of metrics related to UTF-8 support from gauges to counters.
What this PR does
This PR enables the rollout-operator serviceAccount to use podSecurityPolicies.
Which issue(s) this PR fixes or relates to
Currently mimir has the possibility to use podSecurityPolicies for all components with the exception of the rollout-operator,
which makes the deployment of the rollout-operator impossible in an environment, where the use of podSecurityPolicies are active.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]