query-scheduler: instrument number of cancelled requests #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colega
approved these changes
Dec 12, 2022
To help determine the impact of issue 3695 I am adding a counter to measure the number of requests that end up being discarded because they are cancelled, but still occupy capacity in the queue. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/instrument-scheduler-cancelled-requests
branch
from
0228236
to
74b7e54
Compare
dimitarvdimitrov
deleted the
dimitar/instrument-scheduler-cancelled-requests
branch
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
To help determine the impact of issue 3695 I am adding a counter to measure the number of requests that end up being discarded because they are cancelled, but still occupy capacity in the queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help determine the impact of #3695 I am adding a counter to
measure the number of requests that end up being discarded because they
are cancelled, but still occupy capacity in the queue.
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com