alerts: Extend MimirAllocatingTooMuchMemory for read-write deployment #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also check mimir-write which contains the ingester, and mimir-backend which is critical (and contains AlertManager).
Also fix previous entry to be consistent with alert naming convention.
pracucci
reviewed
Dec 13, 2022
Also use job_name from config
…TooMuchMemory # Conflicts: # CHANGELOG.md
pracucci
reviewed
Dec 13, 2022
…TooMuchMemory # Conflicts: # CHANGELOG.md
jhesketh
added a commit
to jhesketh/mimir
that referenced
this pull request
Dec 16, 2022
PR grafana#3710 accidentally duplicated an entry in the changelog due to a bad merge resolution during review.
3 tasks
pracucci
pushed a commit
that referenced
this pull request
Dec 16, 2022
PR #3710 accidentally duplicated an entry in the changelog due to a bad merge resolution during review.
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…grafana#3710) * alerts: Extend MimirAllocatingTooMuchMemory for read-write deployment Also check mimir-write which contains the ingester, and mimir-backend which is critical (and contains AlertManager). * Update changelog Also fix previous entry to be consistent with alert naming convention. * Update helm mixin test * Use "instance" instead of "container" Also use job_name from config * Use container_names instead of instance_names * Fix helm test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Extend MimirAllocatingTooMuchMemory for read-write deployment
Also check mimir-write which contains the ingester, and mimir-backend which is critical (and contains AlertManager).
Which issue(s) this PR fixes or relates to
Partial fixes #3366
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]