Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts: Add alert that triggers for idle alertmanager instances #3826

Merged
merged 4 commits into from
Jan 2, 2023

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Dec 29, 2022

What this PR does

This adds an alert to detect alertmanager instances that don't own any tenants.

Which issue(s) this PR fixes or relates to

Fixes #1959

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@flxbk flxbk changed the title Felix/alert idle alertmanager Alerts: Add alert that triggers for idle alertmanager instances Dec 29, 2022
@flxbk flxbk force-pushed the felix/alert-idle-alertmanager branch from d9711df to 0933646 Compare December 29, 2022 12:25
@flxbk flxbk marked this pull request as ready for review December 30, 2022 08:22
@flxbk flxbk requested review from a team as code owners December 30, 2022 08:22
@flxbk flxbk added type/docs Improvements or additions to documentation monitoring/alerts labels Dec 30, 2022
@pracucci pracucci self-requested a review January 2, 2023 09:53
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a nit). Thanks!

Co-authored-by: Marco Pracucci <marco@pracucci.com>
@flxbk
Copy link
Contributor Author

flxbk commented Jan 2, 2023

Thanks for the review!

@pracucci pracucci enabled auto-merge (squash) January 2, 2023 10:18
@pracucci pracucci merged commit 2edf960 into main Jan 2, 2023
@pracucci pracucci deleted the felix/alert-idle-alertmanager branch January 2, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring/alerts type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning alert if a Mimir component doesn't own any tenant
2 participants