Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimirtool: Display correct rule sync summary #3918

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Jan 10, 2023

Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com

What this PR does

Fixes an issue where the number of rules created and updated were reversed.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Fixes an issue where the number of rules created and updated were
reversed.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review January 10, 2023 18:56
@56quarters 56quarters requested a review from a team as a code owner January 10, 2023 18:56
@56quarters 56quarters added bug Something isn't working component/mimirtool labels Jan 10, 2023
Copy link
Contributor

@andyasp andyasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit fc7ea63 into main Jan 11, 2023
@pracucci pracucci deleted the 56quarters/mimir-tool-sync branch January 11, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/mimirtool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants