Add switch to allow enabling overrides-exporter ring #3995
Conversation
flxbk
changed the title
| @@ -24,11 +25,20 @@ | |||
| local containerPort = $.core.v1.containerPort, | |||
| overrides_exporter_port:: containerPort.newNamed(name='http-metrics', containerPort=$._config.server_http_port), | |||
|
|
|||
| local ringConfig = { | |||
There was a problem hiding this comment.
Our jsonnet support two ring backends: consul (default) and memberlist. Look for querySchedulerRingClientConfig and try to come up with something similar. Since in this case both lifecycler and ring client is only used by overrides exporter, you don't need two separate configs for the lifecycler and ring client, but a single overridesExporterRingConfig is enough. Make overridesExporterRingConfig not local, so that it's overrideable (like querySchedulerRingClientConfig).
There was a problem hiding this comment.
Then I would enable it by default with deployment mode is read-write, so we also see the difference in the jsonnet tests (run make jsonnet-tests to update the tests output).
flxbk
force-pushed
the
felix/backend-exporter-ring
branch
from
f4f007c
to
8219634
Compare
| - -memberlist.bind-port=7946 | ||
| - -memberlist.join=dns+gossip-ring.default.svc.cluster.local:7946 | ||
| - -overrides-exporter.ring.store=memberlist |
There was a problem hiding this comment.
This is not correct. Shouldn't be set if the overrides-exporter ring is disabled.
flxbk
force-pushed
the
felix/backend-exporter-ring
branch
from
d736ff3
to
5b6ff22
Compare
What this PR does
This adds jsonnet config for the ring for overrides-exporters and enables it for the read-write deployment mode.
Do changes like this need a changelog entry?
Which issue(s) this PR fixes or relates to
#3806
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]