Remove mmap-based index header reader #4280
Conversation
They're no longer used.
This functionality is now exercised by the other integration tests given the mmap-less index-header reader is now the default.
There was a problem hiding this comment.
LGTM (modulo few comments)! Also, before merging, can you also remove the flag reference from docs/sources/mimir/operators-guide/configure/about-versioning.md?
Only thing I was unsure about here was whether or not we want to remove the -blocks-storage.bucket-store.index-header.stream-reader-enabled flag immediately, or keep it (but ignore it) until the major release after the next major release.
It was experimental, so it's OK to remove it without deprecating it first.
…ndex header reader.
Done. I've also renamed the |
charleskorn
force-pushed
the
charleskorn/remove-mmap-index-header-reader
branch
from
aca6f60
to
50c1909
Compare
* docs: Remove references to mmap in store-gateway Per #4280, we removed use of mmap. This change removes references to it in architecture documentation. It also removes references to features that have been removed such as not using the bucket index. Fixes #8145 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Code review Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
* docs: Remove references to mmap in store-gateway Per #4280, we removed use of mmap. This change removes references to it in architecture documentation. It also removes references to features that have been removed such as not using the bucket index. Fixes #8145 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Code review Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
What this PR does
This PR removes the mmap-based index header reader from the store gateway, and makes the mmap-less index header reader the default.
It also removes the
fileutilpackage, which contained only mmap-related functionality that is no longer used anywhere.Only thing I was unsure about here was whether or not we want to remove the
-blocks-storage.bucket-store.index-header.stream-reader-enabledflag immediately, or keep it (but ignore it) until the major release after the next major release.Which issue(s) this PR fixes or relates to
#3465
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]