Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New internal query result payload format: add support for remote rule evaluation path #4331

Merged
merged 20 commits into from
Mar 8, 2023
Merged

New internal query result payload format: add support for remote rule evaluation path #4331

merged 20 commits into from
Mar 8, 2023

Commits on Mar 8, 2023

  1. Push decodeQueryResponse into query.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4ce23ac View commit details
    Browse the repository at this point in the history

  2. Extract createRequest method.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    fa14adb View commit details
    Browse the repository at this point in the history

  3. Extract JSON decoding to its own type.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0547089 View commit details
    Browse the repository at this point in the history

  4. Select decoder based on response content type.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5637a4e View commit details
    Browse the repository at this point in the history

  5. Add configuration flag to enable requesting the new internal query re… 

    …sult payload format from query-frontends.
    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    aa38bcf View commit details
    Browse the repository at this point in the history

  6. Send appropriate Accept header based on configured format.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3818947 View commit details
    Browse the repository at this point in the history

  7. Add support for decoding responses sent in protobuf format.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    973b77a View commit details
    Browse the repository at this point in the history

  8. Update changelog. 

    # Conflicts:
#	CHANGELOG.md
    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    08437c6 View commit details
    Browse the repository at this point in the history

  9. Fix typo in comment.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    02d622b View commit details
    Browse the repository at this point in the history

  10. Add support for encoding responses in the protobuf query result paylo… 

    …ad format in the query-frontend.
    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    085a6d4 View commit details
    Browse the repository at this point in the history

  11. Refactor integration test to run a new ruler instance for each test c… 

    …ase.
    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9de8d01 View commit details
    Browse the repository at this point in the history

  12. Add integration test for use of protobuf format between ruler and que… 

    …ry-frontend.
    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    89df038 View commit details
    Browse the repository at this point in the history

  13. Add benchmark.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3fbe179 View commit details
    Browse the repository at this point in the history

  14. Implement content negotiation correctly.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c336e1b View commit details
    Browse the repository at this point in the history

  15. Rename types.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    465c545 View commit details
    Browse the repository at this point in the history

  16. Address PR feedback: fix typos 

    Co-authored-by: Marco Pracucci <marco@pracucci.com>
    @charleskorn @pracucci
    charleskorn and pracucci committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3302c9f View commit details
    Browse the repository at this point in the history

  17. Address PR feedback: no need to take receiver

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    573598b View commit details
    Browse the repository at this point in the history

  18. Address PR feedback: take MIME types from decoders.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f5bc9f8 View commit details
    Browse the repository at this point in the history

  19. Address PR feedback: rename defaultFormatter

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e31cb99 View commit details
    Browse the repository at this point in the history

  20. Fix issue introduced during rebase on main.

    @charleskorn
    charleskorn committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    285b4b2 View commit details
    Browse the repository at this point in the history