Upgrade mimir-prometheus #4340
Merged
Upgrade mimir-prometheus #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colega
approved these changes
Mar 2, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
upgrade-mimir-prometheus
branch
from
393723f
to
9493dfe
Compare
Right. I've pushed a CHANGELOG entry with my best attempt to easily describe the bug. |
colega
approved these changes
Mar 2, 2023
colega
reviewed
Mar 2, 2023
| @@ -59,6 +59,7 @@ Querying with using `{__mimir_storage__="ephemeral"}` selector no longer works. | |||
| * [BUGFIX] Ingester: compact out-of-order data during `/ingester/flush` or when TSDB is idle. #4180 | |||
| * [BUGFIX] Ingester: conversion of global limits `max-series-per-user`, `max-series-per-metric`, `max-metadata-per-user` and `max-metadata-per-metric` into corresponding local limits now takes into account the number of ingesters in each zone. #4238 | |||
| * [BUGFIX] Ingester: track `cortex_ingester_memory_series` metric consistently with `cortex_ingester_memory_series_created_total` and `cortex_ingester_memory_series_removed_total`. #4312 | |||
| * [BUGFIX] Querier: fixed a bug which was incorrectly matching series with regular expression label matchers with begin/end anchors in the middle of the regular expression. #4340 | |||
There was a problem hiding this comment.
Also store-gateway, but not important I guess.
There was a problem hiding this comment.
Right. I think my take here is more like "a bug affecting queries, and any query go through the querier".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Today I've merged few PRs in mimir-prometheus to improve and fix the fast regexp matcher. I would like to upgrade the vendored mimir-prometheus to get these improvements.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]