Prefix 'out-of-order-blocks-external-label-enabled' with '.ingester' #4440
Conversation
npazosmendez
force-pushed
the
njpm/fix-ingester-flag
branch
from
a9222e1
to
d04dfca
Compare
npazosmendez
changed the title
CHANGELOG.md
Outdated
| @@ -72,7 +72,7 @@ Querying with using `{__mimir_storage__="ephemeral"}` selector no longer works. | |||
| * [FEATURE] Distributor, ingester: ingestion of native histograms. The new per-tenant limit `-ingester.native-histograms-ingestion-enabled` controls whether native histograms are stored or ignored. #4159 | |||
| * [FEATURE] Query-frontend: Introduce experimental `-query-frontend.query-sharding-target-series-per-shard` to allow query sharding to take into account cardinality of similar requests executed previously. This feature uses the same cache that's used for results caching. #4121 #4177 #4188 #4254 | |||
| * [ENHANCEMENT] Go: update go to 1.20.1. #4266 | |||
| * [ENHANCEMENT] Ingester: added `out_of_order_blocks_external_label_enabled` shipper option to label out-of-order blocks before shipping them to cloud storage. #4182 #4297 | |||
| * [ENHANCEMENT] Ingester: added `out_of_order_blocks_external_label_enabled` shipper option to label out-of-order blocks before shipping them to cloud storage. #4182 #4297 #4440 | |||
There was a problem hiding this comment.
I'm guessing this will make it to 2.7.0, but I don't know enough about the release process to know if editing the changelog here (2.7.0-rc.0) is the right thing to do.
There was a problem hiding this comment.
We should not extend changelog entries from existing releases. This change needs changelog entry in main / unreleased section now.
There was a problem hiding this comment.
I'm guessing this will make it to 2.7.0,
Since this is an experimental feature, I don't think we need to cherry-pick it onto release-2.7 branch.
There was a problem hiding this comment.
Done here db9c497 (#4440)
Just curious: if one wanted to include a hotfix in 2.7.0, what's the right way to update the changelog? Add a new secion 2.7.0-rc.1 and then all the 2.7.0-rc.* entries get combined into 2.7.0 once the release is done?
There was a problem hiding this comment.
It's an experimental feature, so no need to cherry pick it in 2.7. Thanks!
There was a problem hiding this comment.
Add a new secion 2.7.0-rc.1 and then all the 2.7.0-rc.* entries get combined into 2.7.0 once the release is done?
Yes, once final release is done, we collapse all individual -rc sections.
What this PR does
We added this flag here #4182, but should have prefixed it with
ingester..Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]