Rename and add new utilities in integration tests #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename generateSeries to generateFloatSeries, generateNSeries to generateNFloatSeries. But keep alias to generateSeries for easier transition. Add new generator functions for native histograms and update two tests so that they are not unused. Also fix typo in backward compatibility test. Use new pkg/test/histogram.go for generating the samples themselves. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
There was a problem hiding this comment.
The previous generateSeries is used in a lot of places. What's your plan for those? I see in two of them in this PR you alternated between generateFloatSeries and generateHistogramSeries for every other series. Do you plan to do the same for all other (49) usages too?
… index Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dimitarvdimitrov
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename generateSeries to generateFloatSeries, generateNSeries to generateNFloatSeries. But keep alias to generateSeries for easier
transition.
Add new generator functions for native histograms and update two tests so that they are not unused.
Also fix typo in backward compatibility test.
Use new pkg/test/histogram.go for generating the samples themselves.
What this PR does
Which issue(s) this PR fixes or relates to
Related to: #3478
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]