Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tzdata to alpine dockerfiles #4583

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

nasonfish
Copy link
Contributor

@nasonfish nasonfish commented Mar 23, 2023

What this PR does

This PR populates the /usr/share/zoneinfo by installing timezones using apk on alpine.

Which issue(s) this PR fixes or relates to

Fixes #4582

Allows use of timezones for alertmanager.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@nasonfish nasonfish requested a review from a team as a code owner March 23, 2023 15:32
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small adjustment. Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@56quarters 56quarters merged commit f390c0b into grafana:main Mar 23, 2023
@nasonfish nasonfish deleted the tzdata-dockerfiles branch March 24, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone information is not included in mimir and mimirtool
3 participants