Update mimir-prometheus to optimize regular expression label matchers with alternates #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with alternates Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Apr 1, 2023
| @@ -48,7 +48,8 @@ | |||
| * [ENHANCEMENT] Store-gateway: use more efficient chunks fetching and caching. #4255 | |||
| * [ENHANCEMENT] Query-frontend and ruler: add experimental, more performant protobuf internal query result response format enabled with `-ruler.query-frontend.query-result-response-format=protobuf`. #4331 | |||
| * [ENHANCEMENT] Ruler: increased tolerance for missed iterations on alerts, reducing the chances of flapping firing alerts during ruler restarts. #4432 | |||
| * [ENHANCEMENT] Querier and store-gateway: optimized `.*` and `.+` regular expression label matchers. #4432 | |||
| * [ENHANCEMENT] Optimized `.*` and `.+` regular expression label matchers. #4432 | |||
There was a problem hiding this comment.
Note to reviewers: I modified this because it's not true it applies to querier, but applies to ingesters and store-gateways and query-frontend (query sharding). So, to simplify it, I've just removed to which components apply.
Logiraptor
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
@Logiraptor did a fantastic job on grafana/mimir-prometheus#463 to optimise regular expression label matchers with alternates, and I want to get it merged before the end of the week, so that it will be included in the next weekly release.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]