Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: release 4.5.0-rc.0 #5322

Conversation

krajorama
Copy link
Contributor

What this PR does

Make the 4.5.0-rc.0 release.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • N/A CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama requested review from a team as code owners June 23, 2023 09:50
@krajorama krajorama added helm type/docs Improvements or additions to documentation labels Jun 23, 2023
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small suggestion to add more details about graphite-web


## Important changes

- **The `graphite-web` component was removed** from the graphite proxy. The `graphite-web` component had several configuration issues which meant it was failing to process requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add more details from the PR that changed it. What was graphite-web responsible for and why was it removed? I think #5133 has a good description, so maybe you can just copy from there

graphite-web is used to render queries that the native query engine cannot.

the majority of graphite functions and features are supported by the native GEM graphite query engine, and we're currently working on supporting the remaining few issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I've formatted the text and added it, going to ask @osg-grafana for a review after the fact. Merging to get the chart tested.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama enabled auto-merge (squash) June 23, 2023 12:49
@krajorama krajorama merged commit bd27a2e into mimir-distributed-release-4.5 Jun 23, 2023
17 checks passed
@krajorama krajorama deleted the krajo/update-mimir-distributed-release-4.5 branch June 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants