Introduce -ingester.ring.spread-minimizing-join-ring-in-order CLI flag #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/spread-minimizing-tg
branch
from
cd36f0b
to
fd42276
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/spread-minimizing-tg
branch
from
fd42276
to
75ad364
Compare
pracucci
reviewed
Jul 19, 2023
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a new experimental configuration flag
-ingester.ring.spread-minimizing-join-ring-in-orderthat allows an ingester to register tokens in the ring only after all previous ingesters (with ID lower than its own ID) have already been registered.Which issue(s) this PR fixes or relates to
Part of #4736
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]