Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MimirProvisioningTooManyActiveSeries alert #5593

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

pracucci
Copy link
Collaborator

What this PR does

I propose to remove MimirProvisioningTooManyActiveSeries warning alert. Why?

  • The alert is not actionable. The fact that we have more than 1.6M series per ingester is not an issue per-se. We run production clusters with an higher average number of series and it's not an issue.
  • We have per-ingester max series limit which is an hard stop on the max series in the ingester, and we also have the alert MimirIngesterReachingSeriesLimit: this alert triggers with warning severity when in-memory series reach the 80% of limit and with critical severity when reach the 90%.
  • We have other limits triggering if ingester is under pressure, for example MimirAllocatingTooMuchMemory. In my opinion this is a better alert than just looking at the number of in-memory series.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@56quarters
Copy link
Contributor

This change makes sense to me. I can't remember the last time we (Grafana) alerted on this. I think the per-instance limit and alert makes a lot more sense than the average number of series.

@pracucci pracucci marked this pull request as ready for review July 27, 2023 09:54
@pracucci pracucci requested review from a team as code owners July 27, 2023 09:54
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci
Copy link
Collaborator Author

None shouted against this. I'm going to merge, but we can quickly revert if there are stronger opinions.

@pracucci pracucci merged commit 242f6ac into main Jul 28, 2023
28 checks passed
@pracucci pracucci deleted the remove-ProvisioningTooManyActiveSeries branch July 28, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants