Move error samplers from Limiter to Ingester #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/sampled-error-logging
branch
from
63e16ce
to
120c651
Compare
…dMetricLimitExceeded Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
colega
reviewed
Sep 13, 2023
colega
reviewed
Sep 13, 2023
Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In PR #5584 we introduced sampled logging of errors. The logic of sampling is implented in the
Samplerstruct. The samplers are currently stored in thesamplersfield ofLimiter.This PR moves the
samplersfield fromLimitertoIngester(and renames it toerrorSamplers), which is a more appropriate place for storing them.Moreover, it improves the already existing tests
TestIngester_SampledUserLimitExceededandTestIngester_SampledMetricLimitExceededby ensuring that samples errors get tracked by thecortex_discarded_samples_totalcounter.Which issue(s) this PR fixes or relates to
Relates to #1900, #5894
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]