Configure server side TLS via Vault if enabled #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayzal-g
force-pushed
the
vault-server-tls
branch
from
a6e96e9
to
8f44b71
Compare
pstibrany
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
lgtm. Any chance for adding a unit test for this?
Perhaps we could add "Mock SecretsEngine" to vault.Config and if it's set, then just return
if cfg.Mock != nil { return &Vault{KVStore: cfg.Mock} }from vault.NewVault(cfg). Then we can test if initVault updates all the right places (readers, server config).
WDYT?
|
Yup, sounds like a good idea. Will add a test for this. |
fayzal-g
force-pushed
the
vault-server-tls
branch
from
8f44b71
to
5d8997f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fetches the certificates and keys required to configure server-side TLS from Vault if it is enabled.