Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default -blocks-storage.tsdb.series-hash-cache-max-size-bytes from 1GB to 350MB #6130

Merged

Conversation

pracucci
Copy link
Collaborator

What this PR does

When we introduced the series hash cache, we initially set the default -blocks-storage.tsdb.series-hash-cache-max-size-bytes setting to a random number (1GB). In this PR I propose to upstream a config change we recently did at Grafana Labs and change the default setting to 350MB, which is enouch to store the hashes for all series queried from an ingester, assuming the 13h TSDB retention (default) and up to 2M in-memory series in the ingester.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…from 1GB to 350MB

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review September 25, 2023 15:05
@pracucci pracucci requested review from a team as code owners September 25, 2023 15:05
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pracucci pracucci merged commit 5275545 into main Sep 25, 2023
28 checks passed
@pracucci pracucci deleted the change-blocks-storage.tsdb.series-hash-cache-max-size-bytes branch September 25, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants