Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Vault authentication methods #6143

Merged
merged 8 commits into from
Sep 29, 2023

Conversation

fayzal-g
Copy link
Contributor

@fayzal-g fayzal-g commented Sep 27, 2023

What this PR does

Adds support for new authentication methods for Vault. Can now auth via AppRole, Kubernetes, UserPass or Token

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pkg/vault/vault.go Outdated Show resolved Hide resolved
@fayzal-g fayzal-g marked this pull request as ready for review September 29, 2023 09:07
@fayzal-g fayzal-g requested review from grafanabot and a team as code owners September 29, 2023 09:07
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Left tiny comments to fix before merging, but lgtm overall.

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/vault/auth.go Show resolved Hide resolved
pkg/vault/auth.go Show resolved Hide resolved
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany merged commit 824e3d6 into grafana:main Sep 29, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants