Fix name and default of log burst size #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
the docs about experimental features should also be updated. They mention the old flag name
mimir/docs/sources/mimir/configure/about-versioning.md
Lines 137 to 141 in d8f7a46
This parameter is a _size_, not a _rate_. Name it correctly. Also, I don't think we want processes to be able to output 25,000 lines instantaneously - that's what the rate limit was intended to avoid. Changed the default to 1,000.
bboreham
force-pushed
the
fix-burst-desc
branch
from
4b01394
to
a17fe90
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This parameter is a size, not a rate. Name it correctly.
Also, I don't think we want processes to be able to output 25,000 lines instantaneously - that's what the rate limit was intended to avoid. Changed the default to 1,000.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]