Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated CLI flags in jsonnet and doc #6319

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

pracucci
Copy link
Collaborator

What this PR does

I noticed jsonnet and doc still references the old (deprecated) store-gateway index-header lazy loading CLI flags. In this PR I'm switching to new ones.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pracucci pracucci marked this pull request as ready for review October 10, 2023 16:19
@pracucci pracucci requested review from a team as code owners October 10, 2023 16:19
@pracucci pracucci merged commit 57f8f53 into main Oct 10, 2023
28 checks passed
@pracucci pracucci deleted the fix-jsonnet-store-gateway-lazy-load-config branch October 10, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants