Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mimir-prometheus@d0d6240125f9 #6446

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 20, 2023

What this PR does

Upgrade to mimir-prometheus@d0d6240125f9, which brings in grafana/mimir-prometheus#546, that fixes a bug affecting ingesters, where canceled queries may get cached (thus failing also consecutive requests, due to the poisoned cache entry).

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 marked this pull request as ready for review October 20, 2023 14:57
@aknuds1 aknuds1 requested review from grafanabot and a team as code owners October 20, 2023 14:57
@aknuds1 aknuds1 added bug Something isn't working component/ingester labels Oct 20, 2023
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @charleskorn spotting it and thanks @aknuds1 for upgrading mimir-prometheus.

@aknuds1 aknuds1 enabled auto-merge (squash) October 20, 2023 15:15
@aknuds1 aknuds1 merged commit 3e88e46 into main Oct 20, 2023
32 checks passed
@aknuds1 aknuds1 deleted the arve/upgrade-prometheus branch October 20, 2023 15:24
francoposa pushed a commit that referenced this pull request Oct 20, 2023
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/ingester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants