Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in scheduler processor #6573

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Nov 6, 2023

What this PR does

Scheduler processor (part of Querier) is creating gRPC client to frontend, to send result back, and it needs to use gRPC client settings for query-frontend.

Bug was introduced in #6445.

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…result. It needs to use frontend client config.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner November 6, 2023 09:11
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany enabled auto-merge (squash) November 6, 2023 09:26
@pstibrany pstibrany merged commit 0f6d6e5 into main Nov 6, 2023
28 checks passed
@pstibrany pstibrany deleted the fix-scheduler-processor-grpcclient branch November 6, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants