Ingester: Base memory utilization on Go heap size #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
added
bug
aknuds1
force-pushed
the
arve/memory-utilization-based-ingester-limiting
branch
4 times, most recently
from
a5595b4
to
f9a063c
Compare
aknuds1
changed the title
aknuds1
force-pushed
the
arve/memory-utilization-based-ingester-limiting
branch
2 times, most recently
from
08ce83d
to
78db976
Compare
aknuds1
changed the title
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/memory-utilization-based-ingester-limiting
branch
from
78db976
to
21ac558
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
dimitarvdimitrov
approved these changes
Nov 16, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Modify the utilization based ingester read path limiter to base memory utilization on Go heap size instead of RSS from /proc/self/ (Linux procfs). The motivation is that we have experienced significant practical divergence between procfs and cAdvisor (container) memory measurements, and after a design discussion we've arrived at trying to track the Go heap size instead for simplicity.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]