Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 part-size flag to configure the S3 minimum file size in bytes used for multipart uploads #6592

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

mlech-reef
Copy link
Contributor

@mlech-reef mlech-reef commented Nov 7, 2023

What this PR does

It adds S3 part-size flag to configure the S3 minimum file size in bytes used for multipart uploads

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mlech-reef mlech-reef requested review from a team as code owners November 7, 2023 18:55
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

@dimitarvdimitrov
Copy link
Contributor

thanks for the contribution! Can you share some details for how this config is helping? perhaps we can improve the default value and avoid increasing the config surface

@mlech-reef
Copy link
Contributor Author

thanks for the contribution! Can you share some details for how this config is helping? perhaps we can improve the default value and avoid increasing the config surface

Thank you for quick replay. This parameter is already available in Thanos S3 provider, however, we would like to use Mimir.
I believe the default value is tweaked by Thanos for AWS S3, but if you like to use a different S3-compatible API, the other value can have more sense, depends on the provider, the network capacity and speed. I can not give exact value.
Another reason to have it, is that you can set it to minio maximum value 5GB to completely disable multipart uploads. This is actually our use case, as Backblaze B2 that we use doesn't support x-amz-checksum-* headers added by minio by default for multipart upload and this can not be disabled neither in Thanos and Mimir.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants