Distributor: Don't use global logger in push handlers #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/otel-logger
branch
from
892bbbb
to
342bda5
Compare
ying-jeanne
reviewed
Nov 14, 2023
| var decoderFunc func(buf []byte) (pmetricotlp.ExportRequest, error) | ||
|
|
||
| logger := log.WithContext(ctx, log.Logger) |
There was a problem hiding this comment.
I think we can leave the log.WithContext, it adds traceid as part of logger, which spanlogger.NewWithLogger doesn't seems to do it.
There was a problem hiding this comment.
@ying-jeanne but handler calls this function (as parser) with a logger that's instantiated with request context. Do you agree that we no longer need the log.WithContext call in this function (since it's already been done by handler)?
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Modify the Distributor's push handlers to receive the API's logger instead of using the global one (we're supposed to migrate off the global logger). A practical benefit from this is that the OTLP push handler receives the
handlerfunction's logger, which includes source IPs.Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]