Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog, flag not removed #6699

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix changelog, flag not removed #6699

merged 1 commit into from
Nov 21, 2023

Conversation

krajorama
Copy link
Contributor

What this PR does

Fix changelog.

Which issue(s) this PR fixes or relates to

Followup to #6673

Checklist

  • N/A Tests updated.
  • N/A Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

Followup to #6673

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@@ -5,7 +5,6 @@
### Grafana Mimir

* [CHANGE] The following deprecated configurations have been removed: #6673
* `-querier.query-ingesters-within`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I got confused about what was removed in 1d6581c; it was the query_ingesters_within YAML field, not this flag, which already got moved in #4287.

Should we add to the change log about the removed YAML field instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. i think so. I'll merge this PR

@krajorama krajorama merged commit 8359e55 into main Nov 21, 2023
28 checks passed
@krajorama krajorama deleted the krajo/fix branch November 21, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants