Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue introduced in #5342.
We shouldn't consider
PENDING
ingesters as unhealthy: in the case where new ingesters have just started due to a scale-up, we'll consider each zone with aPENDING
ingester as unhealthy, and so if two zones have just scaled up and havePENDING
ingesters, the query will fail.Furthermore, we should attempt to query ingesters in the
PENDING
state: in the case where an ingester has just started, queriers may have only observed the ingester in thePENDING
state, but distributors may have observed the ingester in theACTIVE
state and started sending samples, for example:PENDING
state to ringPENDING
stateACTIVE
ACTIVE
If we don't query the new zone A ingester that the querier still thinks is
PENDING
, then we'll miss the sample that is only in zone A and C.Note that the downside of this change is that queriers will attempt to query ingesters that are possibly still starting up, and may not be ready to receive requests. In this case, hedging will cause the querier to try other ingesters, if available, after at most 2s, or sooner if the connection to the ingester fails before hedging is triggered, and one of the following will happen:
ACTIVE
, but I will add this in a follow up PR (Prefer querying ingester zones with the least number of non-ACTIVE ingesters #6727)Which issue(s) this PR fixes or relates to
Related: #5342
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.