Upstream internal jsonnet changes #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
approved these changes
Nov 28, 2023
4 tasks
pracucci
approved these changes
Nov 28, 2023
operations/mimir/config.libsonnet
Outdated
| @@ -69,6 +69,7 @@ | |||
| storage_azure_account_key: error 'must specify Azure account key', | |||
|
|
|||
| jaeger_agent_host: null, | |||
| querier_jaeger_reporter_max_queue_size: 5000, | |||
There was a problem hiding this comment.
Don't think we need to allow to configure it. An user can always override it in querier_env_map.
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…-matchers-cache-max-bytes Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…-matchers-cache-max-bytes Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
upstream-jsonnet-changes
branch
from
e899065
to
6f7e5a5
Compare
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
|
@56quarters @pracucci I've upstreamed another change from our jsonnet: However, instead of changing jsonnet / helm, I've opted to change default value used by ingester. WDYT? |
pracucci
approved these changes
Nov 29, 2023
pkg/storage/tsdb/config.go
Outdated
Comment on lines
90
to
96
| // This increase is most useful on Mimir clusters with 1 tenant. If the tenant runs very high cardinality | ||
| // queries (e.g. a query touching 1M series / ingester) then with the default cache | ||
| // size of 10MB we may not be able to effectively use the cache. | ||
| // | ||
| // A single cached posting takes about 9 bytes in the cache, on average. The default max cache size as number of items | ||
| // is 100, so having a 100MB cache per-tenant for the TSDB Head means we can cache 100MB / 100 / 9 = 116k postings | ||
| // per cached entry on average. |
There was a problem hiding this comment.
Please rephrase it. It says "with the default cache size of 10MB" which is no more the case.
There was a problem hiding this comment.
Good point, thanks. Updated the comment.
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR upstreams some of the changes that we use internally.
JAEGER_REPORTER_MAX_QUEUE_SIZEto 5000 to avoid dropping of spansChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.