Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingester client: context canceled is not an error #6809

Merged
merged 1 commit into from
Dec 8, 2023
Merged

ingester client: context canceled is not an error #6809

merged 1 commit into from
Dec 8, 2023

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Dec 4, 2023

What this PR does

Don't output this kind of message , which we tend to get by the hundred:

ts=2023-12-04T11:58:07.821737148Z caller=spanlogger.go:109 method=SeriesChunksStreamReader.StartBuffering user=279486 level=error msg="received error while streaming chunks from ingester" err="context canceled"

Don't mark spans as errored either.

Checklist

  • NA Tests updated.
  • NA Documentation added.
  • NA CHANGELOG.md updated
  • NA about-versioning.md updated with experimental features.

@bboreham
ingester client: context canceled is not an error
497fb7b 
Don't log it or mark spans as errored.
@bboreham bboreham requested a review from a team as a code owner December 4, 2023 12:07
colega
colega approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@colega colega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. This message is also misleading for a lot of people.

charleskorn
charleskorn approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bboreham

@bboreham bboreham merged commit c2d7bf3 into main Dec 8, 2023
28 checks passed
@bboreham bboreham deleted the dont-log-streaming-canceled branch December 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colega colega colega approved these changes

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @colega @charleskorn