Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of comment posted during build image CI builds #6872

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix formatting of comment posted during build image CI builds #6872

merged 2 commits into from
Dec 11, 2023

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR fixes the issue where backticks are incorrectly escaped in the comment posted on PRs by CI that modify the build image, for example:

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6868-e4be452cf9`. This can take up to 1 hour.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review December 11, 2023 04:02
@charleskorn charleskorn requested a review from a team as a code owner December 11, 2023 04:02
dimitarvdimitrov
dimitarvdimitrov approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@charleskorn charleskorn merged commit aab75eb into main Dec 11, 2023
28 checks passed
@charleskorn charleskorn deleted the charleskorn/build-image-workflow branch December 11, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

@ying-jeanne ying-jeanne Awaiting requested review from ying-jeanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @dimitarvdimitrov