helm: omit backend: s3 when minio is disabled
#6999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to having to manually override the value of `blocks_storage.backend` when using something other than S3. This shouldn't break existing installations because S3 is already the default in Mimir. This was prompted by [this comment](#1901 (comment)) by ksingh-scogo (thanks!) For example: ```yaml mimir: structuredConfig: common: storage: backend: azure azure: account_key: "<YOUR KEY HERE>" account_name: <ACKT_NAME> endpoint_suffix: "blob.core.windows.net" blocks_storage: backend: azure ## Without this it doesn't work azure: container_name: mimir-dev-blocks ``` Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Logiraptor
approved these changes
Dec 28, 2023
dimitarvdimitrov
deleted the
dimitar/helm/disable-explicit-s3-setting-when-not-using-minio
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to having to manually override the value of
blocks_storage.backendwhen using something other than S3. This is already how the ruler and alertmanager storages work.This shouldn't break existing installations because S3 is already the default in Mimir.
This was prompted by this comment by @ksingh-scogo (thanks!)
For example: