Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'msteams' to TestMultitenantAlertmanager_FirewallShouldBlockHTTPBasedReceiversWhenEnabled #7050

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Jan 4, 2024

What this PR does

In #5840 we've added msteams support to Alertmanager. Whenever we add support for a new receiver, we're used to test it in TestMultitenantAlertmanager_FirewallShouldBlockHTTPBasedReceiversWhenEnabled. In this PR I'm adding it.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…asedReceiversWhenEnabled

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review January 4, 2024 10:58
@pracucci pracucci requested review from a team as code owners January 4, 2024 10:58
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch - thanks!

@pracucci pracucci merged commit ed7844f into main Jan 4, 2024
28 checks passed
@pracucci pracucci deleted the add-msteams-to-TestMultitenantAlertmanager_FirewallShouldBlockHTTPBasedReceiversWhenEnabled branch January 4, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants