Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to Grafana Agent Operator CRDs #7084

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 9, 2024

The location where Grafana Agent Operator CRDs is changing to a new folder as part of grafana/agent#6077. The old link still works, but it will stop working in a few days after all references to the old links have been removed.

@rfratto rfratto requested review from a team as code owners January 9, 2024 15:50
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link looks good to me

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening the PR. There are few other references to the current URL in some other docs and in the helm chart values.yaml. Can you replace them too? https://github.com/search?q=org%3Agrafana+%22production%2Foperator%2Fcrds%22+repo%3Agrafana%2Fmimir&type=code

The location where Grafana Agent Operator CRDs is changing to a new
folder as part of grafana/agent#6077. The old link still works, but it
will stop working in a few days after all references to the old links
have been removed.

Signed-off-by: Robert Fratto <robertfratto@gmail.com>
@rfratto rfratto force-pushed the rfratto/update-agent-operator-crds-url branch from 9052bb9 to b7f08f7 Compare January 10, 2024 13:11
@rfratto
Copy link
Member Author

rfratto commented Jan 10, 2024

@dimitarvdimitrov Thanks, I missed those on my initial search. I replaced the remaining references and they should all be correct now.

@rfratto
Copy link
Member Author

rfratto commented Jan 10, 2024

FWIW, since the Mimir docs were referencing the main branch of grafana/agent, you'll want to consider backporting these changes to older versioned docs of Mimir.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dimitarvdimitrov dimitarvdimitrov merged commit 2b45d86 into main Jan 10, 2024
32 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the rfratto/update-agent-operator-crds-url branch January 10, 2024 16:21
grafanabot pushed a commit that referenced this pull request Jan 10, 2024
The location where Grafana Agent Operator CRDs is changing to a new
folder as part of grafana/agent#6077. The old link still works, but it
will stop working in a few days after all references to the old links
have been removed.

Signed-off-by: Robert Fratto <robertfratto@gmail.com>
(cherry picked from commit 2b45d86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants