-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update link to Grafana Agent Operator CRDs #7084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for opening the PR. There are few other references to the current URL in some other docs and in the helm chart values.yaml. Can you replace them too? https://github.com/search?q=org%3Agrafana+%22production%2Foperator%2Fcrds%22+repo%3Agrafana%2Fmimir&type=code
The location where Grafana Agent Operator CRDs is changing to a new folder as part of grafana/agent#6077. The old link still works, but it will stop working in a few days after all references to the old links have been removed. Signed-off-by: Robert Fratto <robertfratto@gmail.com>
9052bb9
to
b7f08f7
Compare
@dimitarvdimitrov Thanks, I missed those on my initial search. I replaced the remaining references and they should all be correct now. |
FWIW, since the Mimir docs were referencing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
The location where Grafana Agent Operator CRDs is changing to a new folder as part of grafana/agent#6077. The old link still works, but it will stop working in a few days after all references to the old links have been removed. Signed-off-by: Robert Fratto <robertfratto@gmail.com> (cherry picked from commit 2b45d86)
The location where Grafana Agent Operator CRDs is changing to a new folder as part of grafana/agent#6077. The old link still works, but it will stop working in a few days after all references to the old links have been removed.