Handle context.Canceled in active series requests
#7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
approved these changes
Jan 11, 2024
flxbk
force-pushed
the
felix/active-series-context-canceled
branch
from
99f6681
to
29ba882
Compare
grafanabot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Handle context.Canceled errors in callback for `forReplicationSet` (cherry picked from commit cc3a1b3)
flxbk
added a commit
that referenced
this pull request
Jan 11, 2024
* Handle context.Canceled errors in callback for `forReplicationSet` (cherry picked from commit cc3a1b3) Co-authored-by: Felix Beuke <felix.j.beuke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The invocation of the active series
ingesterQuerythroughforReplicationSetcan be canceled via its context if the quorum has been established otherwise. In these cases, we should not return an error fromingesterQuery.Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.