Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for /active_series #7106

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Small fixes for /active_series #7106

merged 4 commits into from
Jan 11, 2024

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Jan 11, 2024

What this PR does

This contains four small changes related to the active series API:

  • Make request queue scheduling dimension extraction aware of active series requests.
  • Add the current json parser buffer to the error message in cases where a querier responds with an unexpected response.
  • Log the error message.
  • Do not pass along the Accept-Encoding header from the query-frontend to upstream services, because its value has been consumed in the query-frontend itself and its presence could lead to unexpected behaviour of upstream components.

Which issue(s) this PR fixes or relates to

Fixes n/a

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@flxbk flxbk marked this pull request as ready for review January 11, 2024 13:39
@flxbk flxbk requested a review from a team as a code owner January 11, 2024 13:39
@flxbk flxbk changed the title Various fixes for /active_series Small fixes for /active_series Jan 11, 2024
@flxbk flxbk merged commit bc4f4ee into main Jan 11, 2024
28 checks passed
@flxbk flxbk deleted the felix/active-series-fixes branch January 11, 2024 14:29
grafanabot pushed a commit that referenced this pull request Jan 11, 2024
* Do not forward `Accept-Encoding` header

* add parsed json to error

* fix queue dimension for active series queries

* log error

(cherry picked from commit bc4f4ee)
flxbk added a commit that referenced this pull request Jan 11, 2024
* Do not forward `Accept-Encoding` header

* add parsed json to error

* fix queue dimension for active series queries

* log error

(cherry picked from commit bc4f4ee)

Co-authored-by: Felix Beuke <felix.j.beuke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants